fix: Store BLSVerificationVector on disk using basic bls scheme #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Sep 19, 2023
## Issue being fixed or feature implemented Grabbed this from #5480. ## What was done? Cleans quorum data from evoDB for old quorums. ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Co-authored-by: UdjinM6 <[email protected]>
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
fix_vvec_store
branch
from
900d0f7 to
0dc1e70
Compare
UdjinM6
changed the title
UdjinM6
force-pushed
the
fix_vvec_store
branch
from
0dc1e70 to
c96addf
Compare
UdjinM6
force-pushed
the
fix_vvec_store
branch
from
c96addf to
1302beb
Compare
PastaPastaPasta
previously approved these changes
Jan 7, 2024
knst
reviewed
Jan 7, 2024
UdjinM6
dismissed stale reviews from PastaPastaPasta and ogabrielides
via
a4142f0
UdjinM6
force-pushed
the
fix_vvec_store
branch
from
1302beb to
a4142f0
Compare
UdjinM6
force-pushed
the
fix_vvec_store
branch
from
a4142f0 to
9ba595e
Compare
|
Had to rebase on Actual changes brought by the applied suggestion https://github.com/dashpay/dash/compare/1302beb1c80238c1136986113d9a3bd6179af0b9..a4142f0d44a5191194d036ebfb36507451d54fe7 |
PastaPastaPasta
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Shouldn't change the way data is stored on mainnet/testnet nodes since they use basic bls scheme anyway now. For devnets/regtest (which activate v19 again and again) this patch should fix potential issues reading pre-fork data right after the fork.
What was done?
Pls see individual commits
How Has This Been Tested?
Run tests, run a node on testnet
Breaking Changes
n/a
Checklist: